search

bowers-illinois-edu / community-maps

Online map drawing
http://bowers-illinois-edu.github.com/community-maps/
2 stars 0 forks source link

Double emails? #188

Closed jwbowers closed 12 years ago

jwbowers commented 12 years ago

Should we have two emails per comment? Probably not.

markmfredrickson commented 12 years ago

No. How do we know there are 2 per comment?

-M

On Fri, Mar 30, 2012 at 10:45 PM, Jake Bowers reply@reply.github.com wrote:

Should we have two emails per comment? Probably not.

Reply to this email directly or view it on GitHub: https://github.com/bowers-illinois-edu/community-maps/issues/188

jwbowers commented 12 years ago

See the gmail account. At least I think this is happening.

On Mar 31, 2012, at 8:56 PM, Mark Fredricksonreply@reply.github.com wrote:

No. How do we know there are 2 per comment?

-M

On Fri, Mar 30, 2012 at 10:45 PM, Jake Bowers reply@reply.github.com wrote:

Should we have two emails per comment? Probably not.

Reply to this email directly or view it on GitHub: https://github.com/bowers-illinois-edu/community-maps/issues/188

Reply to this email directly or view it on GitHub: https://github.com/bowers-illinois-edu/community-maps/issues/188#issuecomment-4863356

markmfredrickson commented 12 years ago

Agreed. This suggests people are being saved twice, which is surprising, but usually not harmful. I'll look into it.

markmfredrickson commented 12 years ago

Ok. I know why this is happening. When a user writes a comment, we check during the save step to see if there is a comment for this step number. If so, we email. Then, on the next screen the user object gets saved again in order to store a timestamp for starting the page. The problem is that the system checks again for a comment and sees one that corresponds to the previous step and emails again.

If it is not a big deal, I might mark this as a "won't fix", at least for the duration of this survey. We don't seem to be hitting our limit of emails now that we got that sorted out, and while it is inconvenient to have doubles, if we know that will be the case, it is easy to work around.

jwbowers commented 12 years ago

I'm ok with this, esp if Mark is the email potentate. On Apr 7, 2012, at 11:11 AM, Mark Fredrickson wrote:

Ok. I know why this is happening. When a user writes a comment, we check during the save step to see if there is a comment for this step number. If so, we email. Then, on the next screen the user object gets saved again in order to store a timestamp for starting the page. The problem is that the system checks again for a comment and sees one that corresponds to the previous step and emails again.

If it is not a big deal, I might mark this as a "won't fix", at least for the duration of this survey. We don't seem to be hitting our limit of emails now that we got that sorted out, and while it is inconvenient to have doubles, if we know that will be the case, it is easy to work around.

Reply to this email directly or view it on GitHub: https://github.com/bowers-illinois-edu/community-maps/issues/188#issuecomment-5009667

jwbowers commented 12 years ago

I think that Daniel's RA is the email potentate and thus close this issue.