search

bowhan / piPipes

piRNA pipeline collection developed in the Zamore Lab and ZLab in UMass Med School
GNU General Public License v3.0
56 stars 40 forks source link

modernized draw_ping_pong function #40

Closed alexfriman closed 3 months ago

alexfriman commented 3 months ago

Due to changes in ggplot2 API calls, original draw_ping_pong function produced a plot without x-label ticks and generated multiple warning messages. This patch resolves it, and the resulting plot is informative.

yfu commented 3 months ago

Could you add some example plots here? Thanks!

alexfriman commented 3 months ago

ping_pong_original In the first screenshot original function does not produce X-axis ticks, and there is a warning message. ping_pong_MODIFIED In the second screenshot, the modified function produces X-axis ticks, and no warnings.

alexfriman commented 3 months ago

Have to add, the "\t" symbols in the plot title create additional warning messages on MacOS. The screenshot above were taken on Linux machine.

yfu commented 3 months ago

Have to add, the "\t" symbols in the plot title create additional warning messages on MacOS. The screenshot above were taken on Linux machine.

Thanks!