search

bowiedev / github-action-wpengine-ssh-deploy

9 stars 12 forks source link

/entrypoint.sh: 6: /entrypoint.sh: WPE_SSHG_KEY_PRIVATE: Required secret not set. #6

Open BenBroide opened 3 years ago

BenBroide commented 3 years ago

I set the secret and still get this error. Also seems from github docs that the secret varible should be set as CamelCase https://docs.github.com/en/actions/reference/encrypted-secrets

BenBroide commented 3 years ago

Also this required keys should be WPENGINE_SSHG_KEY_PUBLIC: ${{ secrets.PUBLIC_KEY_NAME }} WPENGINE_SSHG_KEY_PRIVATE: ${{ secrets.PRIVATE_KEY_NAME }}

Keys should be WPE_SSHG_KEY_PRIVATE WPE_SSHG_KEY_PUBLIC

Even when I change to correct ones, files does not push to server after shows it deployed successfully
If i set a fake environment its still shows deployed successfully

bowiedev commented 3 years ago

Hey there, We've updated the sample yaml to reflect the updated SSH Key names. Those were trimmed for consistency with other code examples and less syntax.

stevensullivan commented 3 years ago

In the future, it would be great if you stored releases in GitHub. That way we could point to a specific release and update when convenient. You can also store change logs in the versions that inform people of the changes they need to make when updating.

https://github.com/bowiedev/github-action-wpengine-ssh-deploy/releases

Thanks!