bowlarbear / arctica

FOSS Bitcoin Core Miniscript Multisignature Desktop Wallet for General Purpose Hardware
MIT License
1 stars 0 forks source link

Avoid hardcoding dependencies #63

Closed BenWestgate closed 10 months ago

BenWestgate commented 10 months ago

In https://github.com/bowlarbear/arctica/blob/8b80a9e792b6ba3f4d84f327ec714272ac5c9d34/src/init.rs#L199C1-L199C123

I noticed the name and version number of all dependencies is hard coded, this requires you manually pushing updates whenever your upstream does.

This can cause delays in new arctica installs receiving important security updates for their dependencies.

You would simplify your life to have a file with a list of dependencies and their minimum versions and let the script iterate over it and fetch the latest minor version (major versions you may still want to manually push as they can break backwards compatibility), same for when you are copying them to the backup USB sticks.

bowlarbear commented 10 months ago

duplicate https://github.com/bowlarbear/arctica/issues/35