search

bowser-js / bowser

a browser detector
Other
5.48k stars 486 forks source link

"darwin" in userAgent does not resolve correctly #481

Open BrandonALittle opened 3 years ago

BrandonALittle commented 3 years ago

Running tests with jest locally: window.navigator.userAgent of the browser is: Mozilla/5.0 (darwin) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/16.5.3

Bowser.parse("Mozilla/5.0 (darwin) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/16.5.3") resolves to { browser: { name: 'Safari' }, os: {}, platform: {}, engine: { name: 'Blink' } }

However, in my CircleCI pipeline,: window.navigator.userAgent of the browser is: Mozilla/5.0 (linux) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/16.5.3

Bowser.parse("Mozilla/5.0 (linux) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/16.5.3") resolves to { browser: { name: 'Safari' }, os: { name: 'Linux' }, platform: { type: 'desktop' }, engine: { name: 'Blink' } }

I think Bowser.parse() should be able to handle darwin, but if you think this can be resolved somehow with jsdom, please let me know.