Add JSON Toolkit to Bowtie

bowtie-json-schema / bowtie

JSON Schema in every programming language

https://bowtie.report/

Other

52 stars 40 forks source link

Add JSON Toolkit to Bowtie #1293

Closed jviotti closed 3 months ago

jviotti commented 3 months ago

Still a very WIP, but would like to work on it in the open to make it easier to pair debug if needed (as I never added an implementation before!)

See: https://github.com/sourcemeta/jsontoolkit

📚 Documentation preview 📚: https://bowtie-json-schema--1293.org.readthedocs.build/en/1293/

jviotti commented 3 months ago

@Julian I think I did it well, but a bit unsure about the exception handling part. Should I return an errored object inside results?

jviotti commented 3 months ago

Ah, no. It's a top-level thing. OK. I think I did it well now

jviotti commented 3 months ago

Looks like we are still getting some check issues even after my changes:

Julian commented 3 months ago

I still don't see you adding a dependabot section. Maybe you didn't push? Or else I'll leave a comment with what you need to add in the file.

Julian commented 3 months ago

Never mind I forgot GitHub review is awful and doesn't let you leave comments on arbitrary lines. But you need a block like what's on line 153 of the dependabot.yml:

  - package-ecosystem: "docker"
    directory: "/implementations/cpp-jsontoolkit"
    schedule:
      interval: "daily"

jviotti commented 3 months ago

Done @Julian ! Also, the actual job seems to have passed.

jviotti commented 3 months ago

Yay! The check is green now :)

Julian commented 3 months ago

Woohoo. Looks great, will merge, congrats/thanks!

jviotti commented 3 months ago

Awesome! Let me know when its up so I can take a look at the results!

Julian commented 3 months ago

You're live! https://bowtie.report/#/implementations/cpp-jsontoolkit