box.phar Require Error - Githubissues

clwells commented 6 years ago

I'm sure I'm being dumb and have looked through all of the issues and I'm the only dumb one with this issue. Have tried a few versions back. I've got the cloned version of box working just fine - just trying to use the phar version.

[root@cloudhost-44385 clwells]# wget https://github.com/humbug/box/releases/download/3.0.0-beta.0/box.phar
Saving to: ‘box.phar’
100%[======================================>] 1,811,772   5.02MB/s   in 0.3s   
2018-06-06 14:20:23 (5.02 MB/s) - ‘box.phar’ saved [1811772/1811772]

[root@cloudhost-44385 clwells]# php ./box.phar 
PHP Fatal error:  require(): Failed opening required 'bin/check-requirements.php' (include_path='.:/opt/remi/php71/root/usr/share/pear:/opt/remi/php71/root/usr/share/php:/usr/share/pear:/usr/share/php') in phar:///chroot/home/nexcess.net/clwells/box.phar/.box/check_requirements.php on line 15

[root@cloudhost-44385 clwells]# php --version
PHP 7.1.17 (cli) (built: Apr 25 2018 07:24:50) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2018 Zend Technologies
    with the ionCube PHP Loader (enabled) + Intrusion Protection from ioncube24.com (unconfigured) v10.2.0, Copyright (c) 2002-2018, by ionCube Ltd.
    with Zend OPcache v7.1.17, Copyright (c) 1999-2018, by Zend Technologies

theofidry commented 6 years ago

Hm this is very weird, I can't manage to reproduce it (I used the same link as you, thanks for giving it).

Could you provide more details on the:

distrib
php config php -i?

clwells commented 6 years ago

Yep, I figured :D. It's a CentOS 7 box. I will try on a few others as well.

`$ php -i`

theofidry commented 6 years ago

🤔 I'm a bit lost tbh. It's one of the either:

the distrib (unlikely)
the PHP config (but I don't see which setting could cause that)

Could it be that being in a chroot environments play a role there? Could you give it a shot outside of it?

clwells commented 6 years ago

It's not chroot'd - but it is an SCL version of PHP. Will dig into and PR something if I can sort out what's going on.

theofidry commented 6 years ago

Closing for now as it doesn't really look related to Box. That being said, Box does provide some help to work around PHP & PHAR's limitations (e.g. to allow to compress a PHAR although without Box it would fail due to too many files open). So if you do find something that Box could help with, please report it :)

phroggar commented 6 years ago

I had this on a created phar (as well as with the box.phar too) and after some trial and error i got my phar working with using the default stub instead of the box stub:

"stub": false

The system i got the error on was a docker container CentOS 7.4 .

I'm missing the requirements checker for now, but the phar is working flawlessly now.

theofidry commented 6 years ago

🤔 this is really troubling.

Can you try:

Take the default stub and put it in an external file
Use that file as the custom stub

You can try again to build the PHAR, so far it shouldn't fail since in the end, you are using the default stub but this one is coming from a file instead of a $phar->setDefaultStub().

Now, assuming the above works fine, can you try to add the requirement checker manually in the file like it is done in the custom Box stub and then check the result? This is to know if the issue comes from the custom stub itself or from the requirement checker which is included in the stub.

Sorry to be dependent on you for this, I cannot test under a CentOS machine :(

phroggar commented 6 years ago

I'm getting the same error when adding:

include 'phar://'.__FILE__.'/.box/check_requirements.php';

in the default stub.

When including

include 'phar://'.__FILE__.'/.box/bin/check-requirements.php';

the checker is working as advertised.

The first file is just including the latter one, but without any phar:// prefix:

namespace KevinGH\Box\RequirementChecker;

require 'bin/check-requirements.php';

I'm new to creating phars myself, but as there is nothing else in that file i'd assume this could be the potential culprit.

theofidry commented 6 years ago

Thanks, I'll look into it ASAP

theofidry commented 6 years ago

Could you try again my replacing:

<?php

/*
 * This file is part of the box project.
 *
 * (c) Kevin Herrera <kevin@herrera.io>
 *     Théo Fidry <theo.fidry@gmail.com>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace KevinGH\Box\RequirementChecker;

require 'bin/check-requirements.php';

By:

<?php

/*
 * This file is part of the box project.
 *
 * (c) Kevin Herrera <kevin@herrera.io>
 *     Théo Fidry <theo.fidry@gmail.com>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace KevinGH\Box\RequirementChecker;

require __DIR__.'/bin/check-requirements.php';
// Or if the above doesn't work:
include 'phar://'.__FILE__.'/.box/bin/check-requirements.php';

In the PHAR? The offending file is box.phar/.box/check_requirements.php

theofidry commented 6 years ago

In all fairness I'm wondering why there is .box/check_requirements.php and then .box/bin/check_requirements.php, maybe the former could be removed

phroggar commented 6 years ago

I would think so too, just get rid of the "empty" file.

box-project / box

box.phar Require Error #253