box-project / box2

An application for building and managing Phars.
https://box-project.github.io/box2/
MIT License
1.19k stars 80 forks source link

My ignore list doesn't work #128

Closed ptondereau closed 8 years ago

ptondereau commented 8 years ago

Hello, Thanks for your great product !

I've got a problem with my box.json :

{
  "alias": "my-cli.phar",
  "chmod": "0755",
  "directories": [
    "src",
    "bin",
    "vendor"
  ],
  "files": [],
  "finder": [
    {
      "in": "vendor",
      "exclude": [
        "myclabs",
        "phpspec",
        "phpdocumentor",
        "phpunit",
        "phpunit-test-case",
        "Tester",
        "Tests",
        "tests",
        "yaml"
      ]
    }
  ],
  "git-version": "package_version",
  "main": "my-cli.php",
  "output": "my-cli.phar",
  "web": false,
  "stub": true,
  "compression": "BZ2"
}

Indeed, while I compile with this command: php -d phar.readonly=0 box.phar build I can see in phar archive that it compress my excluded files and it seems it doesn't care about my box.json...

Any ideas ?

kherge commented 8 years ago

When you build your phar, do the other settings seem to work? The most obvious sign would be that the phar is generated using the name you set in "output".

ptondereau commented 8 years ago

Yes, it outputs it with the name set in my json

kherge commented 8 years ago

Is your project publicly available? I'd like to see the output of the build process myself.

ptondereau commented 8 years ago

Unfortunaly, no. It's private... Sorry Le 31 déc. 2015 01:25, "Kevin Herrera" notifications@github.com a écrit :

Is your project publicly available? I'd like to see the output of the build process myself.

— Reply to this email directly or view it on GitHub https://github.com/box-project/box2/issues/128#issuecomment-168099506.

kherge commented 8 years ago

Could you please recreate the issue with a new project that you can share? It doesn't have to be anything elaborate, it could be as little as just having a composer.json and box.son file.

ptondereau commented 8 years ago

Thank you for your help but I solved my problem:

I've just deleted my composer.lock and run composer update

It now compress perfectly !