box-project / box2

An application for building and managing Phars.
https://box-project.github.io/box2/
MIT License
1.19k stars 80 forks source link

Added support for LSB init parameter stub generation #136

Closed baspeters closed 8 years ago

baspeters commented 8 years ago

This pull request adds LSB init parameter support to box. It depends on this pull request on box2-lib

Documentation update and unit tests are provided with this PR

kherge commented 8 years ago

@baspeters I really appreciate the time and effort you put into this PR, but I do not want to include things that are platform specific. I would look into developing a side project for generating init scripts for phars on different platforms.

baspeters commented 8 years ago

Thanks for your feedback and opinion. The way I see it is that the project already has platform specific features. Take for example the shebang option, this is *nix only but is safely ignored in windows. This PR would basically be the same, as it would be safely ignored on platforms outside of Linux. And very much like the shebang option this PR bootstraps platform specific runtime information that could otherwise not be provided.