Compress files on add instead of using Phar::compressFiles (fixes #80)

box-project / box2

An application for building and managing Phars.

https://box-project.github.io/box2/

MIT License

1.19k stars 80 forks source link

Compress files on add instead of using Phar::compressFiles (fixes #80) #137

Open remisauvat opened 8 years ago

remisauvat commented 8 years ago

Apply file compression when adding a file instead of using Phar::compressFiles at the end. This avoid the issue of opening too many files.

On my project the build even runs faster for ~1200 files.

Tests with compressFiles:

Building...

real    0m23.524s
user    0m14.499s
sys     0m8.972s

New version with compress on the fly

Building...

real    0m19.612s
user    0m10.440s
sys     0m9.135s

lordgnu commented 7 years ago

Hoping this will get reviewed soon and merged into next release. Since I am restricted to using the Phar file release, I have had to disable compression in order to allow our project to build which has increased the resulting phar file size by 600%

theofidry commented 6 years ago

I'm not really convinced of the results: https://github.com/humbug/box/pull/29

Did I miss something?

remisauvat commented 6 years ago

I cannot access the blackfire graphs. Can you upload a screenshot ?

theofidry commented 6 years ago

Damn, looks like I accidentally deleted them. I'll redo them tonight

theofidry commented 6 years ago

Profiles updated

remisauvat commented 6 years ago

Still the link here https://github.com/humbug/box/pull/29#issue-290215315 give a 404 not found

theofidry commented 6 years ago

Should be fixed, I forgot to make them public