box-project / box2

An application for building and managing Phars.
https://box-project.github.io/box2/
MIT License
1.19k stars 80 forks source link

Box does not use the compression #162

Open rugk opened 7 years ago

rugk commented 7 years ago

If I change the compression setting in https://github.com/rugk/threema-msgapi-sdk-php/tree/536457329376dc657cb02a558c9dd8d802af2b67 to "GZ" or "BZIP2" the file is still not compressed.

Issue information:

$ box build # with compression set to something else then "NONE"
Building...
$ box info threema_msgapi.phar 
API Version: 1.1.0

Archive Compression: None

Signature: SHA-256

Signature Hash: 9237AEBAE677E88841C59D2CB8276FC00C5C4909BDFDD322975477385249D12A

General information:

$ php -v                                 
PHP 5.6.29-0+deb8u1 (cli) (built: Dec 13 2016 16:02:08) 
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2016, by Zend Technologies
    with Xdebug v2.2.5, Copyright (c) 2002-2014, by Derick Rethans
$ box info                    
API Version: 1.1.1

Supported Compression:
  - GZ
  - BZIP2

Supported Signatures:
  - MD5
  - SHA-1
  - SHA-256
  - SHA-512
  - OpenSSL
rugk commented 7 years ago

Here is an example: https://github.com/rugk/threema-msgapi-sdk-php/commit/436b5ca59d84239647b003b34e288e0d16723ace

theofidry commented 6 years ago

@rugk actually it does, see https://github.com/humbug/box/issues/20