Release `4.2.3` still includes Android Support Library Annotations in POM

ashughes commented 4 years ago

[x] I have checked that the SDK documentation doesn't solve my issue.
[x] I have checked that the API documentation doesn't solve my issue.
[x] I have searched the Box Developer Forums and my issue isn't already reported (or if it has been reported, I have attached a link to it, for reference).
[x] I have searched Issues in this repo and my issue isn't already reported.

Description of the Issue

This repo has already been completely migrated to AndroidX, however, the artifact for release 4.2.3 still includes the Android Support Library Annotations as a dependency in the POM. This causes the Android Support Library Annotations to be included as a transitive dependency for any projects that use the Box SDK (which prevents disabling the Jetifier).

Steps to Reproduce

Add implementation 'com.box:box-android-sdk:4.2.3' to a sample project that uses only AndroidX dependencies.
Add Can I drop Jetifier? to the sample project.
Run ./gradlew -Pandroid.enableJetifier=false canIDropJetifier

Expected Behavior

This should output No dependencies on old artifacts! Safe to drop Jetifier.

Error Message

Instead this outputs:

Cannot drop Jetifier due to following external dependencies:

* com.box:box-android-sdk:4.2.3
  \-- com.android.support:support-annotations:26.1.0

Versions Used

Android SDK: 29 Android: 10

ashughes commented 4 years ago

FYI, I ran Can I drop Jetifier? on this repo and got the following output:

> Task :box-content-sample:canIDropJetifier
========================================
Project box-content-sample
========================================

No dependencies on old artifacts! Safe to drop Jetifier.

> Task :box-content-sdk:canIDropJetifier
========================================
Project box-content-sdk
========================================

No dependencies on old artifacts! Safe to drop Jetifier.

So just confirming that the repo itself doesn't have any Android Support Library references and the issue is just with the POM in the artifact.

This also means you can remove android.enableJetifier=true from gradle.properties in this repo. I created PR #433 to do this.

guillaume-tgl commented 3 years ago

Can you please fix this?

box / box-android-sdk