box / box-content-preview

JavaScript library for rendering files stored on Box
https://developer.box.com/docs/box-content-preview
Other
106 stars 113 forks source link

"Press down" is not required in annotation Draw mode. #1393

Closed m-nakamura145 closed 3 years ago

m-nakamura145 commented 3 years ago

Environment:

Desktop (please complete the following information):

Steps to reproduce the problem:

  1. Enable showAnnotations option in ContentExplorer
  2. Preview a PDF file.
  3. Click "Drawing annotation mode"

What is the expected behavior? (Screenshots can be helpful here) Annotations can be created by simply dragging the pointer. Press Down in the message is not necessary. Is my understanding correct?

What went wrong? (Screenshots, console logs, or HAR files can be helpful here)

I think the Press Down in the message is not necessary.

Expected behavior I think the correct message is "Drag the pointer to draw on the document".

Screenshots

Screen Shot 2021-05-28 at 16 05 12
ConradJChan commented 3 years ago

Hi @m-nakamura145, thanks for your ticket.

Some initial thoughts are that "Press down" might have been included because drag alone might be ambiguous to some users. Also that this is the legacy annotations codebase and is not actively maintained unless there is a critical bug that needs to be addressed.

This also seems more appropriate for the box-annotations repository. Please reopen the ticket there if you feel it is necessary.