fix(preview): fix auto scroll issue with embed preview

box / box-content-preview

JavaScript library for rendering files stored on Box

Other

106 stars 113 forks source link

Closed Machoper closed 1 year ago

Machoper commented 1 year ago

Scrolling jumps to bottom of page on embedded multi-page previews

Add { block: 'nearest' } as param to scrollIntoView() to prevent the parent scrollbar from jumping around
Fix a type to pass lint check

auto_scroll_before

auto_scroll_after

karelee7 commented 1 year ago

Can we also test it out on different browsers just to be safe?

Machoper commented 1 year ago

Did you test that scrolling works as usual non-embedded? Can you also test on different browser sizes?

@JChan106 Yes, scrolling works well in the Webapp across all browser sizes.

Can we also test it out on different browsers just to be safe?

@karelee7 Yes, I have tested on all supported browsers.

Adding two more gifs for reference

Safari + embedded: auto_scroll_safari

MS Edge + non-embedded: auto_scroll_edge