box / box-content-preview

JavaScript library for rendering files stored on Box
https://developer.box.com/docs/box-content-preview
Other
106 stars 113 forks source link

feat(pdfjs): upgrade pdf.js to 4.3.136 #1517

Closed ahorowitz123 closed 4 months ago

ahorowitz123 commented 5 months ago

Comparison of bundle sizes: Previous version 279K Sep 18

New version Screenshot 2024-05-28 at 4 47 01 PM

ahorowitz123 commented 4 months ago

We should figure out what impact this change is going to have on performance, especially if the new viewer assets are significantly larger than the old ones.

I've found this difficult to test in dev due to the large fluctuations in loading times due to dev infrastructure. I think we'll get a better idea in staging

bfoxx1906 commented 4 months ago

Can we update the description to explain the external link fix with why it was necessary and how the fix works. It'll be helpful for folks down the road to understand why we did this and to be able to tell if we still need it or not.