Closed loonskai closed 3 weeks ago
This is a massive PR - tremendous work but hard to review. I know it is difficult to push each PR separately, but is way easier to meaningfully review so maybe split more next time :)?
Another thought - or rather question. I do know that EUA uses special tooling based on RTL. Don't remember details, but it integrates Redux somehow. Do you know why it was needed there and if it might be here?
This is a massive PR - tremendous work but hard to review. I know it is difficult to push each PR separately, but is way easier to meaningfully review so maybe split more next time :)?
+1 for me. Amazing job and great effort 🎉
Splitting the PR by feature or folder would make a significant difference. It would not only make it easier to review but also easier for you to work on the changes (in terms of time and capacity) and quicker to merge bit by bit instead of blocking the merge for the entire PR due to comments on a single file.
Description
Tests with Enzyme migrated: 23/61
This PR is a part of Box-wide migration to the newer React v18.
fireEvent
executed on top of specific selectors instead of recommendeduserEvent
. Some of these tradeoffs could be avoided (possibly) but would extend the timelines of this PR. I suggest improve these test iteratively as we work on them.data-testid
attributes were added mostly for container elements to quickly validate if container is rendered.data-testid
changes mentioned above)This PR will be followed with the next steps:
Screenshots