search

box / box-ios-sdk

iOS SDK for the Box Content API
https://developer.box.com
Apache License 2.0
122 stars 113 forks source link

fix: Remove use of deprecated string scanner API. #901

Closed jlawton closed 1 year ago

jlawton commented 1 year ago

Goals :soccer:

Remove use of deprecated scanHexInt32.

Implementation Details :construction:

While making the change to dataFromHexString it became clear that this method wasn't actually needed. It's there in order to take a hexadecimal string encoding of a hash and re-encode it to a base64, but simply skipping the production of the hex from the data in the first place makes the method unnecessary.

Testing Details :mag:

Tested sha1() method manually.

coveralls commented 1 year ago

Coverage Status

coverage: 88.488% (-0.08%) from 88.569% when pulling df2f38ab5673b2bc585023471eccde7d2cbf3e7c on jl/hash-fix into f46c3c018f1577fb1628e53c4c0720bd005e6e75 on main.