box / box-node-sdk

A Javascript interface for interacting with the Box API. You can find the node package at
https://www.npmjs.com/package/box-node-sdk
Apache License 2.0
187 stars 121 forks source link

Wrong type definition in the createWithUserID and createWithGroupID functions #832

Closed yaelsch closed 1 year ago

yaelsch commented 1 year ago

Description of the Issue

I'm upgrading my SDK version to "3.0.0" and noticed that the type definition of userId in client.collaborations.createWithUserID and groupId in client.collaborations.createWithGroupID is set to number although in the rest of the code it is set to string (e.g. groups.addUser)

Steps to Reproduce

Simply try to call these functions with a string and you get a TS error

Expected Behavior

Screenshots

image

Versions Used

Node SDK: "3.0.0"

lukaszsocha2 commented 1 year ago

Hi, thanks for reporting this issue. We will solve it asap. Best, @lukaszsocha2