box / box-python-sdk

Box SDK for Python
http://opensource.box.com/box-python-sdk/
Apache License 2.0
419 stars 215 forks source link

feat: Add support for Python 3.10 #692

Closed adamchainz closed 2 years ago

adamchainz commented 2 years ago

This necessitated an upgrade of pytest and pytest-xdist. I think they were probably only pinned for Python 2 compat.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1824832454


Totals Coverage Status
Change from base Build 1824261162: 0.0%
Covered Lines: 3254
Relevant Lines: 3477

💛 - Coveralls
adamchainz commented 2 years ago

Fixed errors from pytest fixtures being called directly. docs, message (for many tests):

____ ERROR at setup of test_query_with_value_based_filters[20-0-file-None] _____
Fixture "search_entries" called directly. Fixtures are not meant to be called directly,
but are created automatically when test functions request them as parameters.
See docs.pytest.org/en/stable/explanation/fixtures.html for more information about fixtures, and
docs.pytest.org/en/stable/deprecations.html#calling-fixtures-directly about how to update your code.
lukaszsocha2 commented 2 years ago

Thanks for contributing ! Actually the same task was in our roadmap for the next week, but you were faster than us ;) Just one comment to not specify lower limit of pytest library version and we're good to merge it.

adamchainz commented 2 years ago

Thanks for contributing ! Actually the same task was in our roadmap for the next week, but you were faster than us ;) Just one comment to not specify lower limit of pytest library version and we're good to merge it.

It's okay, I had to take a look as I was upgrading a client codebase to Python 3.10 and wanted to be sure Box wouldn't be a risk.

adamchainz commented 2 years ago

Great, cheers.

arjankowski commented 2 years ago

Thank you @adamchainz for your help 👍