Closed allanparsons closed 1 year ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: allanparsons
:x: Allan Parsons
Totals | |
---|---|
Change from base Build 3758880645: | 0.0% |
Covered Lines: | 3404 |
Relevant Lines: | 3640 |
Hi @allanparsons, thanks for contributing. Can you sign our Contributor License Agreement so we can merge your pr?
@lukaszsocha2 this is blocked on an integration test. Since this is tagged with [docs] per the instruction(s), the merge shouldn't be blocked on tests.
Can you force merge?
@allanparsons it's blocked on licence. Integration tests check is optional.
@lukaszsocha2 got it. license was signed prior to PR. I suspect we're waiting on someone on Box's legal side to click the button
Ok let's wait a bit, maybe it will be resolved. If not, maybe a force push will be needed to retrigger the check.
Can you force push this commit to retrigger check?
'Allan Parsons seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.' Something is still missing
There is an email bound to my account but it's private. See screenshot. Wonder if the license check is unable to view a private email address?
I guess it may be the case. Would you mind if I close this pr and open one by myself with exact same change? Or alternatively you could make your email public and check again. Tell me which one would you prefer
Replaced by: PR #785
According to Change Log documentation, logging_network support was removed in version 2.0.0. README documentation was never updated to reflect this removal. This PR resolves that discrepancy between docs and changelog.