search

box / box-python-sdk

Box SDK for Python
http://opensource.box.com/box-python-sdk/
Apache License 2.0
417 stars 214 forks source link

fix: chunked uploader - fix resume error with `sha1` hash #802

Closed hoggatt closed 1 year ago

hoggatt commented 1 year ago

Fixes #495 when the sha1 hash is updated before the uploaded part actually succeeds and something happens that requires resuming, a digest mismatch error is thrown (see issue #495)

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

hoggatt commented 1 year ago

Made this change locally and it ended up fixing the problem. Although I did also update from 3.2 to 3.6.2, but I'm guessing the issue wasn't fixed between those versions.

lukaszsocha2 commented 1 year ago

Hi @hoggatt, thanks for contributing. In recent pr (https://github.com/box/box-python-sdk/pull/800) we have introduced a feature to use multiple threads for chunk upload. Your change was also included in that pr, so I will close this one. New feature will be available soon in new release. Best, @lukaszsocha2