box / box-python-sdk

Box SDK for Python
http://opensource.box.com/box-python-sdk/
Apache License 2.0
413 stars 214 forks source link

feat: adds get sign template and get sign templates methods on Client #835

Closed dtrodger closed 10 months ago

dtrodger commented 11 months ago

Tell @PJSimon Dave Rodgers says hi :)

coveralls commented 11 months ago

Pull Request Test Coverage Report for Build 5831713999


Changes Missing Coverage Covered Lines Changed/Added Lines %
boxsdk/client/client.py 9 10 90.0%
<!-- Total: 15 16 93.75% -->
Files with Coverage Reduction New Missed Lines %
boxsdk/client/client.py 1 86.23%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 5725071206: 0.001%
Covered Lines: 3467
Relevant Lines: 3707

💛 - Coveralls
congminh1254 commented 11 months ago

Hi @dtrodger, I have just added the tests for this sign templates, but it turned out that the response body from API is missing type field, it could make some issue while serialise the object. So I'm contacting with the team who own this API to see if they can add that field to the request body, then we can merge this PR. Thanks for your patience. Regards, Minh