ChunkedUploader Resume Not Closing ThreadPoolExecutor Instances

[Badgeoak]

• [x] I have checked that the SDK documentation doesn't solve my issue.
• [x] I have checked that the API documentation doesn't solve my issue.
• [x] I have searched the Box Developer Forums and my issue isn't already reported (or if it has been reported, I have attached a link to it, for reference).
• [x] I have searched Issues in this repo and my issue isn't already reported.

Description of the Issue

Hi team, long time user, first time issue-opener. Sorry if I missed anything obvious!

The ChunkedUploader's resume method doesn't shut down the ThreadPoolExecutor after it successfully uploads.

I am uploading a few files of a few hundred MB, get a ConnectionError, and successfully call the chunked_uploader.resume() and it completes, but I still see two instances of the ThreadPoolExecutor running. I modified the code in the resumse method as below to double check what I was seeing.

self._executor = ThreadPoolExecutor(max_workers=API.CHUNK_UPLOAD_THREADS, thread_name_prefix='box_resume') And even after the files are uploaded I have box_resume_0 and box_resume_1 in my call stack.

Steps to Reproduce

Start a chunked_uploader on a large enough file Get a ConnectionError Call chunked_uploader.resume()

Expected Behavior

Expect to see threadpool get cleaned up

Versions Used

Python SDK: 3.8.1 Python: 3.9.6

[lukaszsocha2]

Hi @Badgeoak, thanks for posting this issue. Can you check if pasting this line: self._executor.shutdown(wait=True) to line 156 in chunked_uploader.py (just before return statement in _commit_and_erase_stream_reference_when_succeed method) solves your issue ? Best, @lukaszsocha2

[Badgeoak]

@lukaszsocha2 Yep, that seems to do the trick!

[lukaszsocha2]

We will do the fix then, thanks. Best, @lukaszsocha2