box / boxcli

A command line interface for interacting with the Box API.
https://developer.box.com
Apache License 2.0
222 stars 59 forks source link

fix: force offset based pagination in get users #504

Closed mwwoda closed 11 months ago

mwwoda commented 11 months ago

Changing back marker-based pagination to the offset one in GET /users as it causes infinite loop (next_marker is never null) when using together with filter_term.

Need to clarify with service owners as it looks like an API bug, because the next_marker should be null at some point to indicate the end of the result set.

The final page of items has been requested when the next next_marker value is null in the response object. At this point there are no more items to fetch.

https://developer.box.com/guides/api-calls/pagination/marker-based/

coveralls commented 11 months ago

Pull Request Test Coverage Report for Build 6613503391


Totals Coverage Status
Change from base Build 6223463528: 86.5%
Covered Lines: 4165
Relevant Lines: 4662

💛 - Coveralls