search

box / flaky

Plugin for nose or pytest that automatically reruns flaky tests.
Apache License 2.0
378 stars 60 forks source link

Check for setup failures #123

Closed nmalaguti closed 7 years ago

nmalaguti commented 7 years ago

Fixes #120, #117, #124, #114

boxcla commented 7 years ago

Hi @nmalaguti, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

nmalaguti commented 7 years ago

CLA signed

boxcla commented 7 years ago

Verified that @nmalaguti has just signed the CLA. Thanks, and we look forward to your contribution.

nmalaguti commented 7 years ago

My change should not have caused any errors in the Travis tests.

Is there any feedback for this change?

Jeff-Meadows commented 7 years ago

This change does legitimately cause the tox tests to fail with xdist. I'm not totally sure why. This looks good to merge once that's resolved.

nmalaguti commented 7 years ago

So I couldn't get it working with xdist to retry when there was a setup failure, but not retrying on setup failures worked to make sure setup failures don't silently pass.

nmalaguti commented 7 years ago

@Jeff-Meadows things should be good now if you want to take a look.

Jeff-Meadows commented 7 years ago

@nmalaguti I feel like I used to be able to merge things even with failing Travis tests; that appears to no longer be the case. I'm ready to merge this as soon as I can. I fixed a bunch of the Travis tests in another commit, but one pylint error remains - could you add a pylint directive to your test code to ignore the unused argument?

nmalaguti commented 7 years ago

@Jeff-Meadows updated and green!