search

box / flaky

Plugin for nose or pytest that automatically reruns flaky tests.
Apache License 2.0
377 stars 60 forks source link

Remove nose-related tests #171

Open mcepl opened 3 years ago

mcepl commented 3 years ago

I am a maintainer of Python packages in openSUSE, and I am on my crusade of eliminating nose1 from our distribution. When I look at its repository on https://github.com/nose-devs/nose, the last release 1.3.7 was on 2 Jun 2015, and even the last commit on the master branch was on 4 Mar 2016. Moreover it will stop working with Python 3.10.

This patch eliminates dependency on nose, which has been unnecessary for a long time.

stratakis commented 3 years ago

That would be great. Indeed nose is dead for quite some time, maybe changing everything to pytest would be sufficient.

mcepl commented 3 years ago

Actually, you don’t have to even do that. My patch is just plain unittest.

stratakis commented 3 years ago

@Jeff-Meadows pinging here for visibility.

Similar to mcepl I'm one of the Python maintainers for Fedora. We will soon face the same issue on Fedora when we update to Python 3.10 (for which we already test the whole distro against) and removing nose would be of great benefit to us as well.

We have also deprecated nose since the previous Fedora release: https://fedoraproject.org/wiki/Changes/DeprecateNose

Jeff-Meadows commented 3 years ago

Thanks for the ping. I agree there seems to be no point in continuing to support nose.

I'd be happy to review and merge a PR that accomplished the task.

mcepl commented 3 years ago

I'd be happy to review and merge a PR that accomplished the task.

You have patch attached to the first comment of this issue. Sorry, I work with 2000+ Python packages (couple of hundred of them were dependent on nose), so I don't have enough time to clone, fork, and create pull requests for each of them.