search

box / mojito

An automation platform that enables continuous localization.
https://www.mojito.global/
Apache License 2.0
369 stars 74 forks source link

Properties files push makes wrong IDs #782

Open gintsgints opened 2 years ago

gintsgints commented 2 years ago

I have next files:

2100ECepikData.properties
2100ECepikData_de.properties
2100ECepikData_ee.properties
2100ECepikData_fr.properties
2100ECepikData_lt.properties
2100ECepikData_lv.properties
2100ECepikData_pl.properties
2100ELT_TRAVEL_INDIVIDUALCalculator.properties
2100ELT_TRAVEL_INDIVIDUALCalculator_de.properties
2100ELT_TRAVEL_INDIVIDUALCalculator_ee.properties
2100ELT_TRAVEL_INDIVIDUALCalculator_fr.properties
2100ELT_TRAVEL_INDIVIDUALCalculator_lt.properties
2100ELT_TRAVEL_INDIVIDUALCalculator_lv.properties
2100ELT_TRAVEL_INDIVIDUALCalculator_pl.properties

But when I issue commands to import:

java -jar /mojito/mojito-cli.jar repo-create -n issue -l de,ee,fr,lt,lv,pl
java -jar /mojito/mojito-cli.jar push -r issue

I get second translations as IDs:

 - Uploading: 2100ECepikData.properties
 --> asset id: 1513, task: 13991
 - Uploading: 2100ELT_TRAVEL_INDIVIDUALCalculator.properties
 --> asset id: 1514, task: 13994
 - Uploading: 2100ELT_TRAVEL_INDIVIDUALCalculator_de.properties
 --> asset id: 1515, task: 13998
 - Uploading: 2100ELT_TRAVEL_INDIVIDUALCalculator_ee.properties
 --> asset id: 1516, task: 14004
 - Uploading: 2100ELT_TRAVEL_INDIVIDUALCalculator_fr.properties
 --> asset id: 1517, task: 14008
 - Uploading: 2100ELT_TRAVEL_INDIVIDUALCalculator_lt.properties
 --> asset id: 1518, task: 14017
 - Uploading: 2100ELT_TRAVEL_INDIVIDUALCalculator_lv.properties
 --> asset id: 1519, task: 14024
 - Uploading: 2100ELT_TRAVEL_INDIVIDUALCalculator_pl.properties
 --> asset id: 1520, task: 14032

I would like to get 2100ELT_TRAVEL_INDIVIDUALCalculator as one ID.

aurambaj commented 2 years ago

@gintsgints the bug is due to having _ in the properties base name. It gets confused about which part is the locale and which part is not. I don't have a lot of time to look at it right now. A workaround would be to rename the file 2100EltTravelIndividualCalculator.

Btw, what's the encoding of your properties file? is that for a Java project?

gintsgints commented 2 years ago

Yes. This is for Java project and encoding is UTF-8. Sadly I cannot change underscode placement. It relates to form name.

I will wait patiently while you fix :)