search

boxblinkracer / cypress-testrail

A decoupled TestRail integration for your Cypress project to easily send results to TestRail
MIT License
32 stars 24 forks source link

Add .replace to omit commas in the array of case IDs #25

Closed asalgado87 closed 1 year ago

asalgado87 commented 1 year ago

Commas are being included in some of the case ID strings, causing a 400 response from testrail. I've tested this change on my machine and this fixes the issue.

boxblinkracer commented 1 year ago

hi thank you so much for this do you know whey they are added? do you have a sample test-description where that happens? is this then a bug in the extractor of case ids?

asalgado87 commented 1 year ago

I actually found that someone in our org had included commas separating test case ids. example: 'C1234, C1235, C1236: test case example title'

So it turns out there was an issue with mapping on our side, not an actual bug. This change will provide a guardrail in such a case but isn't totally necessary. I found this out after putting up the pr so apologies for the unnecessary noise.

boxblinkracer commented 1 year ago

Hi aaaa, got it :) no worries regarding the noise,....with your PR its now more bulletproof so im more than happy to merge it

thank you so much