search

boxblinkracer / phpunuhi

PHPUnuhi - The easy composable framework to validate and manage translations
MIT License
72 stars 5 forks source link

DeepL translator valid traget locale #44

Closed TumTum closed 2 months ago

TumTum commented 2 months ago

The DeepL Translator checks the availability of the target language. It doesn't matter whether the country code is included or not.

Fixed command

phpunuhi translate --service=deepl --source=de-DE --force=fr-FR or phpunuhi translate --service=deepl --source=de-DE --force=fr-BE or phpunuhi translate --service=deepl --source=de-DE --force=fr-CH

TumTum commented 2 months ago

@boxblinkracer i have fixed the ci errors :-)

boxblinkracer commented 2 months ago

Hi @TumTum a perfect, so en and pt are special ones and the rest just needs the first part, correct?

thanks for fixing it ill merge it soon :)

pipe looking good now :)

TumTum commented 2 months ago

a perfect, so en and pt are special ones and the rest just needs the first part, correct?

Yes exactly (references). Because we ask Deepl once which languages are available. This can be adjusted automatically in the future. Some have a website in Belgium and France and they need the setting 'fr-BE' and 'fr-FR' in their framework.

Dein Tool ist mega mega cool, es rettet uns!!!

boxblinkracer commented 2 months ago

nice, thanks, ill add it to the changelog

und vielen vielen dank, das freut mich extrem :)