boxcutter / centos

Virtual machine templates for CentOS written in legacy JSON
Apache License 2.0
425 stars 198 forks source link

Use Minimal ISO? #80

Closed TJM closed 5 years ago

TJM commented 6 years ago

I guess I can understand that you don't want both ISOs, but we do not have a need for a desktop vagrant box, and do not want to download the entire DVD for a minimal system. Just a thought?

~tommy

boxcutter-robot commented 6 years ago

Thanks for contributing. The tradeoff is not quite that simple - overall, using the DVD is more reliable/faster when you are doing a lot of builds as you don’t have to rely on a remote mirror for additional files.

That being said, you can always change out the image with different properties. Rather than modifying the main centos7.json, I would suggest that you consider using another filename for the properties, like centos7-minimal.json in your PR to offer that choice while still making the default the DVD.

On Jun 13, 2018, at 9:57 AM, Tommy McNeely notifications@github.com wrote:

I guess I can understand that you don't want both ISOs, but we do not have a need for a desktop vagrant box, and do not want to download the entire DVD for a minimal system. Just a thought?

~tommy

You can view, comment on, or merge this pull request online at:

https://github.com/boxcutter/centos/pull/80 https://github.com/boxcutter/centos/pull/80 Commit Summary

Use Minimal ISO File Changes

M centos7.json https://github.com/boxcutter/centos/pull/80/files#diff-0 (6) Patch Links:

https://github.com/boxcutter/centos/pull/80.patch https://github.com/boxcutter/centos/pull/80.patch https://github.com/boxcutter/centos/pull/80.diff https://github.com/boxcutter/centos/pull/80.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/boxcutter/centos/pull/80, or mute the thread https://github.com/notifications/unsubscribe-auth/AL5WAx8r5AnCI3BbfJUmqIIQlh3tGkP6ks5t8USTgaJpZM4Umkso.

TJM commented 6 years ago

Right, like I said, I can see why you are using the DVD for the "-desktop" iteration (although, I can't say that I understand the concept of a vagrant desktop), but for the "base" image, the minimal iso should provide all necessary software. I had started by adding a centos7-minimal.json (var file) https://github.com/TJM/boxcutter-centos/tree/rhel-centos-minimal, but I was also trying to not produce another "box" that is exactly the same as the one produced from "centos7.json" just from a different ISO image. If someone just typed "make build" or whatever (does anyone do that?), it would create two identical images.

I am OK with keeping that change internal only, I just wondered whether it would be useful for anyone else.

boxcutter-robot commented 6 years ago

Very few people do a make build, as it also creates boxes with all the desktop virtualization flavours, so I wouldn’t be too concerned about adding another option.

Actually most people do packer build <whatever>.json and don’t use the Makefile

But for those that do, they generally choose the specific box they want and build one thing make centos7, or possibly make centos7-minimal

On Jun 14, 2018, at 7:25 AM, Tommy McNeely notifications@github.com wrote:

Right, like I said, I can see why you are using the DVD for the "-desktop" iteration (although, I can't say that I understand the concept of a vagrant desktop), but for the "base" image, the minimal iso should provide all necessary software. I had started by adding a centos7-minimal.json (var file) https://github.com/TJM/boxcutter-centos/tree/rhel-centos-minimal https://github.com/TJM/boxcutter-centos/tree/rhel-centos-minimal, but I was also trying to not produce another "box" that is exactly the same as the one produced from "centos7.json" just from a different ISO image. If someone just typed "make build" or whatever (does anyone do that?), it would create two identical images.

I am OK with keeping that change internal only, I just wondered whether it would be useful for anyone else.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/boxcutter/centos/pull/80#issuecomment-397314798, or mute the thread https://github.com/notifications/unsubscribe-auth/AL5WA3b9e1SGoJU3sJIqcQFZqjDBxA-Jks5t8nI7gaJpZM4Umkso.

boxcutter-robot commented 6 years ago

What I’m saying is that even a minimal image involves a network hit to install packages, in some cases. When one is doing repeated builds, a long box build can get interrupted by a tiny blip in the network to a remote mirror, so the default is to cache the DVD image so that all the packages required to do an install are local with a one-time network hit. Not all of the minimal ISOs contain enough files to do a complete install of even a JEOS box (“juice box”). Not your use case from what you describe. But why it is like that.

On Jun 14, 2018, at 7:25 AM, Tommy McNeely notifications@github.com wrote:

Right, like I said, I can see why you are using the DVD for the "-desktop" iteration (although, I can't say that I understand the concept of a vagrant desktop), but for the "base" image, the minimal iso should provide all necessary software. I had started by adding a centos7-minimal.json (var file) https://github.com/TJM/boxcutter-centos/tree/rhel-centos-minimal https://github.com/TJM/boxcutter-centos/tree/rhel-centos-minimal, but I was also trying to not produce another "box" that is exactly the same as the one produced from "centos7.json" just from a different ISO image. If someone just typed "make build" or whatever (does anyone do that?), it would create two identical images.

I am OK with keeping that change internal only, I just wondered whether it would be useful for anyone else.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/boxcutter/centos/pull/80#issuecomment-397314798, or mute the thread https://github.com/notifications/unsubscribe-auth/AL5WA3b9e1SGoJU3sJIqcQFZqjDBxA-Jks5t8nI7gaJpZM4Umkso.

TJM commented 5 years ago

I suppose when installing gcc and company for Virtualbox extensions, you would need packages that are not contained in the minimal iso, since the minimal iso is actually minimal. What is sortof funny is that I was thinking of going another level deeper and going with the netinstall ISO so that everything came from the network. Anyhow, I see why things are the way they are, and there is really no point in keeping this issue open :)

Tommy