search

boxcutter / macos

Virtual machine templates for macOS written in legacy JSON
MIT License
316 stars 65 forks source link

Enabling the Packer vars to be set #5

Closed chrisjohnson1988 closed 9 years ago

chrisjohnson1988 commented 9 years ago

Not able to customize packer build

There is an issue which stops customisation of packer variables via options in Makefile.local.

If you run virtualbox/osx1010-desktop with a simple Makefile.local Something like:

    CM:=puppet

Packer will not receive these arguments and will continue to use those defined inside the target .json file.

What have I done?

I spotted that the PACKER_VARS variable could never be set unless CM_VERSION was defined.

This pull request adjusts to logic of the _ifdef CMVERSION statement so that PACKER_VARS is always set

epu commented 9 years ago

This fixes github #8 which I just filed/opened. I almost duplicated the PR before finding this one. Can you please merge this?

rasa commented 9 years ago

Thanks.

epu commented 9 years ago

No, thank you! Running packer by hand would be tedious. I appreciate boxcutter-osx and your help.