search

boxcutter / macos

Virtual machine templates for macOS written in legacy JSON
MIT License
316 stars 65 forks source link

Merging changes from timsutton osx-vm-template #7

Closed chrisjohnson1988 closed 8 years ago

chrisjohnson1988 commented 9 years ago

Installing of Puppet fails

I think that the way in which AutoPkg is called has changed recently. Meaning that the recipe name must occur at the end of the command.

As the code stands, attempting to install puppet will fail with an error:

virtualbox-iso: Usage: autopkg run [options] [recipe ...]
virtualbox-iso: Run one or more recipes.

What have I done?

I have updated the cmtool.sh script to match @timsutton puppet.sh as it currently exists

timsutton commented 9 years ago

I can confirm that the current state of puppet.sh works, having just done a build last night.

A note on something I just discovered, though: PL makes available a stable URL of "puppet-latest.dmg" at https://downloads.puppetlabs.com/mac - so if you'd prefer to not bother with the logic provided by AutoPkg, that's another option. I could see osx-vm-templates moving towards that instead and letting the template pass in pinned versions or "latest" for the Puppet and Chef tools. I maintain AutoPkg and the Puppet Labs recipes for those, but removing a dependency is always nice.

chrisjohnson1988 commented 9 years ago

Thanks Tim. I was aware that puppet labs hosted the .DMG files. It certainly seems simpler to just download and install those. Certainly something to think about.

I can also confirm that the new code builds in virtualbox.

timsutton commented 9 years ago

Just to clarify, the AutoPkg recipes also fetch these same downloads. At the time I wrote the recipes however (2 years ago), they didn't have the "latest"-named versions posted, so I wrote some additional code to list all the items and sort them by version to pick out the highest one. Looks like that code could be retired now.

Tim

On Tue, Apr 21, 2015 at 11:51 AM, Christopher Johnson < notifications@github.com> wrote:

Thanks Tim. I was aware that puppet labs hosted the .DMG files. It certainly seems simpler to just download and install those. Certainly something to think about.

I can also confirm that the new code builds in virtualbox.

— Reply to this email directly or view it on GitHub https://github.com/boxcutter/osx/pull/7#issuecomment-94849975.

misheska commented 8 years ago

Closed per Tim