search

boxcutter / macos

Virtual machine templates for macOS written in legacy JSON
MIT License
314 stars 65 forks source link

setting CM_VERSION botches the packer command #8

Closed epu closed 9 years ago

epu commented 9 years ago

If users set CM_VERSION to use a specific chef or puppet version, the entire packer command line is truncated.

The issue appears to be this else clause, which should be an endif. The list of packer options should always be expanded.

epu commented 9 years ago

Side effect is that default configuration values from the .json template are always used, even if differences are specified in variables on the command line or from within a Makefile.local. For example, updates will always be applied to new images, even if UPDATE=false.