search

boxcutter / windows

Virtual machine templates for Windows written in legacy JSON and Batch Scripting/JScript
Apache License 2.0
756 stars 264 forks source link

Updated all of the templates to use current Packer schema for specifying the cpus and memory. #170

Closed arizvisa closed 5 years ago

arizvisa commented 5 years ago

This is a large commit, but essentially it updates all of the templates to use Packer's schema for specifying the cpus and memory as per the docs (http://packer.io/docs/builders/virtualbox-iso.html#cpus and http://packer.io/docs/builders/virtualbox-iso.html#memory, etc.)

One of the templates /eval-win7x64-enterprise-cygwin.json seems to hardcode the memory to 3072 instead of using the environment variable memory. This was updated to use the variable (which is set to 3072) as it seems that was what was the original author intended.

The usage of "scis0.virtualDev" in vmx_data for the vmware builders is the same as specifying the disk_adapter_type (http://packer.io/docs/builders/vmware-iso.html#disk_adapter_type) and so this was updated as well.

tas50 commented 5 years ago

Thanks @arizvisa