search

boxcutter / windows

Virtual machine templates for Windows written in legacy JSON and Batch Scripting/JScript
Apache License 2.0
756 stars 264 forks source link

win2012r2-standardcore-ssh.json template has the wrong vm_name for some of the builders #214

Closed arizvisa closed 4 years ago

arizvisa commented 4 years ago

While checking the vm_name for some of the templates, the win2012r2-standardcore-ssh.json template is using the same name for the win2012r2-standardcore.json template. This inconsistency will only affect the template name during building, but prior to post-processing the template into a vagrant box. Things can get funky if you're building both of these templates at the same time from the same directory.

arizvisa commented 4 years ago

Ftr this only affects the vmware-iso, virtualbox-iso, and parallels-iso builders.

This was found with the following jq query:

jq '([.builders[] | .vm_name] | unique) as $names | {name: $names, length: ($names | length) } | select(.length > 1)' *.json
arizvisa commented 4 years ago

This is fixed by PR #215.