search

boxcutter / windows

Virtual machine templates for Windows written in legacy JSON and Batch Scripting/JScript
Apache License 2.0
753 stars 266 forks source link

Deprecated schema options used in some of the templates #219

Closed arizvisa closed 4 years ago

arizvisa commented 4 years ago

A lot of the templates are using deprecated schema options such as ssh_wait_timeout. This isn't a problem because the Packer folks are kind enough to retain these, but packer validate doesn't seem to warn about them.

This issue is just to keep track of schema keys that are deprecated and that packer can change (or remove) in the future. I'll start with the first one that I noticed here: ssh_wait_timeout is deprecated in favor of ssh_timeout.

arizvisa commented 4 years ago

Using vmx_data to set cpuid.coresPerSocket has been deprecated for cores but only in the vmware-iso builder.

arizvisa commented 4 years ago

Closing this due to PR #220 being merged.