boxcutter / windows

Virtual machine templates for Windows written in legacy JSON and Batch Scripting/JScript
Apache License 2.0
753 stars 266 forks source link

Clean up unused files (floppy/oracle-cert.cer) leftover from merging PR #91 #223

Closed arizvisa closed 4 years ago

arizvisa commented 4 years ago

Each builder in all of the templates specifies nearly the same input files excluding one file for the virtualbox-iso builder. This is the floppy/oracle-cert.cer file. After doing research into seeing what it was used for, it was discovered that it's a code-signing certificate that doesn't appear to be even used. More importantly, PR #91 has superseded its usage with commit 0e22a26 which extracts the code-signing certificate directly from the guest additions ISO.

This PR removes that file and updates all of the templates to not reference it anymore. I went through and triple-checked to make sure that nothing else could be referencing the file and my theory appears to be true as there's nothing else that references its '.cer' extension, or anything containing its prefix oracle.

On another note, removing this file makes it easier to look for inconsistencies in the templates as now all of the floppy_files should be the same. This helps get closer to solving issue #221.

This closes issue #222.