Proxy support for Initial install and shell provisioners

[daxgames]

@arizvisa Merge my PRs in the order they were opened for best results. If merging all it should look like this when done.

They are all based on boxcutter/windows master branch.

The first 4 PRs do everything that was in #179

229

230

232

233

This is new based on issues encountered with New Packer 1.5.2

234

Proxy support for Initial install and shell provisioners

• Part of #179 so closing #179
• Adds authenticated/unauthenticated http/https/no_proxy capability to _download.cmd for wget and powershell
  • See README.md for configuration documentation.
  • wget throws a lot of red onto the screen when using proxy so if proxy is configured powershell will be used. Note: this could be a configurable preferrence but I saw no need.
• Moves powershell download to _download.cmd
• documents use of floppy\_packer_config*.cmd
• Add floppy/_packer_config_*.cmd to the .gitignore so users can customize without committing to this repo.

[daxgames]

@arizvisa Proxy support added.

[daxgames]

@arizvisa Still working on adding authenticated proxy.

[daxgames]

@arizvisa This is ready to go. Please ask if you have any questions.

[arizvisa]

Thanks for doing this work. My bad on merging the other ones before reading this. :-/

I just relocated, so I don't have all my equipment setup to simulate this properly. It's likely I'll be able to deploy a quick proxy and build more than a single VM sometime next week, though. However, I'll see what I can do over the weekend so you aren't stuck waiting too long.

[daxgames]

@arizvisa no worries. I oriiginally wrote a less capable version of the proxy support for this I think 3 years ago so I have been waiting for a while.

[arizvisa]

As semi-discussed in #83, the addition of allowing users to customize the configuration during the floppy step (which includes the update to all of the templates) is different from the consolidation of the download methods that you did to implement proxy support.

Can you isolate the configuration (along with the relevant paragraph of documentation) and all of the modifications to the templates into its own PR?

[daxgames]

@arizvisa It was done because it is absolutely required to configure proxy support during floppy step. So it is indeed part of the proxy support PR.

Edit: Let me explain. You don't want someone editing a file that is a part of this repo to add optional configuration. They should be able to add a file that is ignored by git as optional configuration.

[arizvisa]

Is it though? What's wrong with the pre-existing methodology of editing floppy/_packer_config.cmd?

[daxgames]

If you want to protect users and make it easy to use without making bad commits else its REALLY easy to mess up.

git add
git commit -m 'add proxy config'

I just don't see the features as a separate thing. In my opinion floppy/_packer_config*.cmd not being in the packer templates is an oversight that should have always been there.

Maybe DISABLE_BITS should be remove from floppy/_packer_config.cmd but I can see it becoming a default setting where proxy will never become a default setting. Which is why I put it in that file and suggest proxy config go in a user supplied ignored file.

[arizvisa]

Ok. No worries then. I'll do it for you.

[daxgames]

@arizvisa You'll leave it in or take it out? I am not trying to be difficult, just curious.

I mean, I am just pleading my case and trying to convince you. You are the maintainer and have the ultimate say. I just disagree it is a mixed feature PR because the scripts have always had the ability to run multiple floppy/_packer_config*.cmd scripts.

I can make it a separate PR if that is what you really want. Just let me know.

[arizvisa]

Can you re-base this? The differences should be a lot smaller as a result of PR #235.

[daxgames]

@arizvisa Rebased