search

boxcutter / windows

Virtual machine templates for Windows written in legacy JSON and Batch Scripting/JScript
Apache License 2.0
753 stars 266 forks source link

do not fail vmtool.cmd if buildertype is vsphere using Packer 1.5.2+ #234

Closed daxgames closed 4 years ago

arizvisa commented 4 years ago

Nice. That's awesome that Packer split up the conditionals from the vmware- builders into the vsphere- builders while I was gone. Hashicorp is awesome.

daxgames commented 4 years ago

Vsphere-iso and vsphere-clone are two completely new builders that interface with esxi using the vspere api. Originally written by Jetbrains and merged into Packer master as on 1.5.2.

The original vmware builders are still there and do the same as what they used to do for local vmware workstation and esxi builds using ssh to a apecific host.

The vsphere builders are really nice and work well.

arizvisa commented 4 years ago

Ah, was thinking it was related to hashicorp/packer#7212.

There were a number of conditionals in the vmware builders that allowed esx to be split up into two distinctly different builders. Regardless, glad that vsphere builders are separate from the vmware builders instead of it being a number of conditionals that were hacked into the vmware builders.