search

boxcutter / windows

Virtual machine templates for Windows written in legacy JSON and Batch Scripting/JScript
Apache License 2.0
756 stars 264 forks source link

Add support for specifying additional floppy/_packer_config*.cmd files #235

Closed arizvisa closed 4 years ago

arizvisa commented 4 years ago

This PR splits up some of the functionality from PR #229 that allows the user to specify more than one floppy/_packer_config.cmd file as long as the custom configuration corresponds to the glob floppy/_packer_config*.cmd. This is done as the aforementioned functionality requires modifying all of the templates and is an addition claimed by the author of #229's to be a requirement of their PR.

As a consequence, this should simplify the review of the mentioned PR which modifies the functionality of the way in which we download files and at the same time allow other users to link in their own configurations which is relevant to both PRs #229 and #83.

arizvisa commented 4 years ago

Just need to run a smoke test on this really quick to confirm it doesn't break anything even though the logic is minimal.

arizvisa commented 4 years ago

Successfully tested this against the following templates:

$ find box -type f
box/vmware/eval-win10x86-enterprise-nocm-1.0.4.box
box/vmware/.gitignore
box/vmware/eval-win7x86-enterprise-nocm-1.0.4.box
box/virtualbox/.gitignore