search

boxcutter / windows

Virtual machine templates for Windows written in legacy JSON and Batch Scripting/JScript
Apache License 2.0
753 stars 266 forks source link

Modified the "iso_checksum_type" in each of the builders for all of the templates to use a user-variable so that it can be easily customized #236

Closed arizvisa closed 4 years ago

arizvisa commented 4 years ago

This PR moves the "iso_checksum_type" field that is explicitly defined as "sha1" in all the builders into the user-variable section for all of the templates. We already allow the user to specify the "iso_checksum" as a user-variable which allows its customization. So by exposing the checksum type as well, this allows the user to choose whatever checksum they see fit. This allows the user complete control over the iso, its checksum, and its checksum type when building the template.

Each of the builders in all of the templates use a default value of "sha1" for the "iso_checksum_type", so this was used for the default value of the "iso_checksum_type" user variable in order to retain backwards compatibility.

arizvisa commented 4 years ago

All templates seem to validate successfully. I'm going to merge this.