boxcutter / windows

Virtual machine templates for Windows written in legacy JSON and Batch Scripting/JScript
Apache License 2.0
753 stars 266 forks source link

Removed the deprecated `iso_checksum_type` field from all of the available templates #246

Closed arizvisa closed 3 years ago

arizvisa commented 3 years ago

According to a recent call to packer validate after updating, the iso_checksum_type field has now been deprecated in packer v1.6.0. Now it seems that packer determines the checksum type by checking the length of the checksum and using that to distinguish which type to validate with. The existence of this type doesn't seem to cause any other issues, so the removal is purely aesthetic. We should remove this anyways because it causes packer validate to return an error.

This PR does exactly that by using grep -v to cull out the field from each of the templates. The wip/* templates have also been done despite them not really being used for anything.

This should close issue #245.