search

boxcutter / windows

Virtual machine templates for Windows written in legacy JSON and Batch Scripting/JScript
Apache License 2.0
753 stars 266 forks source link

[WIP] Removed the hardcoding of the 2019.2.2 version for "latest" when installing the "salt" configuration management tool #252

Open arizvisa opened 3 years ago

arizvisa commented 3 years ago

Due to issue saltstack/salt#1394 which broke the "latest" parameter to salt-bootstrap, we were forced to explicitly test for it and hardcode the version. As that aforementioned issue was finally closed, this means we can remove this hardcoding from script/cmtool.bat entirely.

The majority of that hardcoding was done by commit 9645c5963291b8379acf75f72a07715b14af4ce8. so we can get by with reverting it and fixing a few things in order to remain consistent. There's still an ssl issue since earlier versions of windows do not support ssl versions earlier than 3. In order to deal with this other issue, this PR adds another script which installs KB3154518 on the platforms that it's necessary for.

This closes issue #251.

arizvisa commented 3 years ago

force-pushed due to rebase after merging of PR #254.

arizvisa commented 3 years ago

This PR is only being held up atm because I still haven't tested this properly against W7. I'm currently on the edge of considering adding another KB due to the latest version of saltstack not bundling a non-SP1 compatible update for W7.

We either need a W7 SP1 evaluation/rtm iso link, or some other way to install the saltstack package without SP1 being installed (similar to the way I'm doing KB2999226). As mentioned, I'm kind of up-in-the-air about this and am considering just warning the user about later versions of SaltStack having potential issues on W7 or maybe fixing it with documentation. I currently have a friend looking into this since he's got msdn accts and stuff, so I'll update this PR when I get some more information from him.