Downloading ultradefrag from sourceforge will sometimes not work if curl or powershell is used as a downloader

boxcutter / windows

Virtual machine templates for Windows written in legacy JSON and Batch Scripting/JScript

Apache License 2.0

756 stars 264 forks source link

Downloading ultradefrag from sourceforge will sometimes not work if curl or powershell is used as a downloader #253

Closed arizvisa closed 4 years ago

arizvisa commented 4 years ago

Occasionally when building a template, the download for ultradefrag fails. This is actually because sourceforge.net sucks and changes the contents of the download redirect depending on the user-agent that a downloader passes in the http request headers.

This affects both the Powershell and curl downloaders, and likely any other platforms where the sanity-check on executing wget.exe fails... So yeah...I really really hate sourceforge.net....

arizvisa commented 4 years ago

Should we update ultradefrag while we're at it? Latest stable-release is 7.1.4, and apparently 7.1.0 has significant performance improvements (kind-of-a-changelog is here: https://sourceforge.net/p/ultradefrag/news/)

I'd rather not as I'd prefer being consistent over anything else, and we've been using 7.0.2 forev..but if someone wants me to bump the version, feel free chime in on that and I'll do it.

arizvisa commented 4 years ago

This issue is fixed by PR #254.