search

boxcutter / windows

Virtual machine templates for Windows written in legacy JSON and Batch Scripting/JScript
Apache License 2.0
756 stars 264 forks source link

Fix shutdown command #256

Closed dragon788 closed 4 years ago

dragon788 commented 4 years ago

Fixes #255

If you aren't using make to build templates you may have run into this issue.

arizvisa commented 4 years ago

Hm. Strange. I'm definitely not using make and haven't encountered this issue yet.

Just curious. What error does it emit in packer during the reboot?

arizvisa commented 4 years ago

Nvm. Saw it in the issue that you posted.

dragon788 commented 4 years ago

Excluding the quotes is primarily to avoid issues with differences between how Windows versions or Packer versions treat them.

I hadn't noticed issues with it shutting down on older versions of Windows 10 when I bypassed make, but after upgrading to Packer 1.6.0 I've had to make a few tweaks due to very subtle behavior changes.

I was actually originally going to file this as an issue with the templates when overriding to a newer version of the Windows 10 ISO but in trying to narrow things down I rediscovered the Makefile overrides and found the quoting issues after using make still worked with the newer ISO.

arizvisa commented 4 years ago

Tested a couple of the eval builds, validated everything but the wip/*.json crap. It all works... Merging.