search

boxcutter / windows

Virtual machine templates for Windows written in legacy JSON and Batch Scripting/JScript
Apache License 2.0
756 stars 264 forks source link

scripts/vmtool.bat broken when setting up VirtualBox guest additions #59

Closed MrCyrus closed 7 years ago

MrCyrus commented 8 years ago

Line 185 vmtool.bat sets VBOX_ISO_PATH to an empty string. Line 189 _download.cmd is called with the vbox URL as the 1st arg but the 2nd arg is empty (since it is VBOX_ISO_PATH) Line 194 then is if not exist "%VBOX_ISO_PATH%" goto exit1 but nothing has set VBOX_ISO_PATH between line 185 and this line so this test ALWAYS fails causing the boxcutter make to fail.

It appears the code is trying to be smart and only download the vbox.iso once so if it already exists, then no need to re-download, but the logic is broken.

A quick workaround is to comment out lines 185->187. Since I'm not a .bat file expert, I'll leave it to someone else to fix/improve this code.

Oddly the original code seems to work on win2012r2 builds but is failing on win2008r2 builds.

tas50 commented 7 years ago

There's been a few PRs against this code and it seems to be functioning now so I'm going to close this out. If you're still having problems feel free to open it back up.