Bump presage and fix receiving direct messages

boxdot / gurk-rs

Signal Messenger client for terminal

GNU Affero General Public License v3.0

458 stars 33 forks source link

Bump presage and fix receiving direct messages #161

Closed gferon closed 2 years ago

gferon commented 2 years ago

Direct messages sent from another device stopped having the recipient's phone number for quite some time now. We're currently looking at removing phone_number fields everywhere in the upstream libraries.

That being said, this PR:

Bumps presage to da3128b which is built on top of all of the latest Signal protobuf schemas, libsignal v0.17.0 and exposes a way to decrypt group changes
Fixes receiving direct messages sent from another device

JFYI, I think you want to test that a bit more than I did before making a release 🤔

mucinoab commented 2 years ago

I tried testing this but the QR is not working, the android app does not recognize it. The QR in the official signal desktop works fine, I just tried it. Can you reproduce this issue?

Edit: never mind, I think it was just cache issues, deleting ~/.local/share/gurk/ solved it.

boxdot commented 2 years ago

The fix was done #162. Upgrading presage is a breaking change due to changed format of the presage db. We would need to bump the minor version of gurk, if we merge this as is. Maybe, we could do automatic migration?

boxdot commented 2 years ago

After #170, it would be impossible to rebase this PR. Also, part of it is merged in #162. Therefore, closing.

gferon commented 2 years ago

I'll send a new PR to bump presage when you're done with your refactoring ⚒️.