QR code doesn't work with light color schemes

boxdot / gurk-rs

Signal Messenger client for terminal

GNU Affero General Public License v3.0

495 stars 38 forks source link

QR code doesn't work with light color schemes #288

Closed 9ary closed 2 months ago

9ary commented 6 months ago

I use a light color palette (Selenized white) in my terminals, and I was unable to link my account without switching to a dark variant.

gurk should be able to control the colors more correctly with true color (which many terminals have adopted support for), or the grayscale ramp from the 256 color palette (which should generally be predictable unless the user has specifically overridden the values).

acidvegas commented 4 months ago

I experienced this also. It's ok I guess cause I just had to use a different terminal color scheme for the setup, after that you dont have to worry about it. But was still annoying.

boxdot commented 2 months ago

We don't setup terminal colors at all. Instead we rely on crossterm backend to do the correct setup for us. I just tested the qr code rendering with the latest crossterm version. The qr code is rendered correctly in kitty with Selenized light theme.

Closing this issue for now. In case, you still have it, please post your terminal and theme. I will test it again.