search

boxdot / gurk-rs

Signal Messenger client for terminal
GNU Affero General Public License v3.0
471 stars 34 forks source link

Duplicate messages #56

Open boxdot opened 3 years ago

boxdot commented 3 years ago

When sending a message in group channels, sometimes it appears multiple times in the chat on other devices.

boxdot commented 3 years ago

Testing if https://github.com/whisperfish/libsignal-service-rs/pull/103 solves the problem.

RancidCrab55 commented 3 years ago

I just experienced the same problem in a normal, non-group chat. The message I sent on gurk is duplicated on my main android client but not for the recipient.

boxdot commented 3 years ago

I can confirm that the problem is still there. The duplicate messages appear not only in Gurk but also in the native Android/Desktop clients. Also, I observed that reactions only appear on a single message. We need to dig deeper into presage.

chaseadam commented 3 years ago

confirm this occurs for me as well in non-group chats. The double message is visible to both participants in native andriod apps.

running v0.2.1

edit: The duplicate message does not display in the desktop app

Sup3Legacy commented 3 years ago

I have a quite different issue. When sending a message, it appears as duplicate on my Android client but neither on my Linux signal-desktop one nor on the participant's one, be it in groups or DMs.

boxdot commented 3 years ago

It's hard to tackle this issue. During the last month I did not have the issue. But yesterday an older build of Gurk reproduced it again. I carefully studied the java and javascript client code of Signal. I don't see anything what we do differently.

boxdot commented 3 years ago

The problems was due to overlapping device IDs stored in the session store for the UUID and the phone number of the user. A fix is proposed here: https://github.com/whisperfish/libsignal-service-rs/pull/108