search

boxed / django-fastdev

An app to make it safer, faster and more fun to develop in Django
BSD 3-Clause "New" or "Revised" License
156 stars 13 forks source link

projectname-X-XXXXXX-py3.XX is not ignored in .gitignore #28

Closed serl closed 1 year ago

serl commented 1 year ago

Hello, First of all, thanks for this app, I find it really helpful to early catch a lot of little things that would otherwise creep up in the least appropriate moment 🙂

I have a problem with the message in the title. I'm using Poetry for this project, that means that the venv name is relatively random, but more importantly, not in my git repository (Poetry has this thing about centralizing the venvs by default).

I really appreciate the app trying to help avoiding committing the entire venv, but I guess that the mechanism should be refined.

I guess that we could improve the check and make sure it doesn't fire if the directory isn't inside the repository (but I can already image some other "problematic" configurations, like having the venv as a subdirectory of an ignored one?). Maybe an easier and more flexible solution would be to have some configuration to manually disable this (and potentially other) check(s)?

Tell me if I can help with a PR 🙂

boxed commented 1 year ago

That's a good point. Yea I'm absolutely open to a PR that does something smarter.